Skip to content

Commit

Permalink
feat: delete database password prompt
Browse files Browse the repository at this point in the history
the database password is now generated automatically and treated as
sensitive by default.
  • Loading branch information
louispaga committed May 14, 2021
1 parent 29531a7 commit 5c5b57d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 5 additions & 1 deletion IaC/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ resource "random_id" "artifacts_bucket_name_suffix" {
byte_length = 5
}

resource "random_password" "password" {
length = 16
}

module "network" {
source = "./modules/network"
network_name = var.network_name
Expand All @@ -44,7 +48,7 @@ module "network" {
module "mlflow" {
source = "./modules/mlflow"
artifacts_bucket_name = "${var.artifacts_bucket}-${random_id.artifacts_bucket_name_suffix.hex}"
db_password_value = var.db_password_value
db_password_value = random_password.password.result
server_docker_image = var.mlflow_docker_image
project_id = var.project_id
consent_screen_support_email = var.consent_screen_support_email
Expand Down
6 changes: 1 addition & 5 deletions IaC/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ variable "artifacts_bucket" {
type = string
default = "oneclick-mlflow-store"
}
variable "db_password_value" {
description = "Database password to connect to your instance"
type = string
}
variable "mlflow_docker_image" {
description = "Docker image used in container registry"
type = string
Expand All @@ -48,4 +44,4 @@ variable "storage_uniform" {
type = bool
description = "Wether or not uniform level acces is to be activated for the buckets"
default = true
}
}

0 comments on commit 5c5b57d

Please sign in to comment.