Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add department filter #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ctcpip
Copy link
Contributor

@ctcpip ctcpip commented Jun 25, 2024

note: this is built on top of the changes from #58. the new changes can be viewed in isolation here.

this feature does the following:

  • loads the currently available departments
    • the departments are cached, and only fetched again after a week or more. (department options virtually never change)
  • renders the options for the user, allowing them to choose
  • stores their choices locally and busts the artwork cache so their preferences take effect immediately
  • choices are used to filter the query used to fetch artworks

additional considerations:

  • we add a none option because there are many artworks that do not have an assigned department
  • there is a contemporary art department, but we get zero results if we filter on it for some strange reason. as such, we exclude this option
  • this also includes some refactoring to share code between the options page and the art tab page, code organization, and layout updates in the options page

resolves #52 and further resolves #19

Screenshot 2024-06-25 at 12 30 21 AM

@ctcpip ctcpip force-pushed the options branch 2 times, most recently from 9a90941 to 3accbb8 Compare June 25, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Departments filter Add settings to Chrome extension
1 participant