Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Jetty 12.1 ee11 #200

Merged
merged 18 commits into from
Nov 13, 2024
Merged

Add support of Jetty 12.1 ee11 #200

merged 18 commits into from
Nov 13, 2024

Conversation

olamy
Copy link
Contributor

@olamy olamy commented May 23, 2024

Signed-off-by: Olivier Lamy [email protected]

Short description of what this resolves:

Changes proposed in this pull request:

Fixes: #

Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
@olamy olamy marked this pull request as ready for review November 7, 2024 02:02
@olamy olamy changed the title add Jetty 12 ee11 Add support of Jetty 12 ee11 Nov 7, 2024
@olamy olamy requested a review from joakime November 7, 2024 02:04
Signed-off-by: Olivier Lamy <[email protected]>
@olamy olamy changed the title Add support of Jetty 12 ee11 Add support of Jetty 12.1 ee11 Nov 12, 2024
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but be aware of the issues around deleteOnExit, consider using a more robust solution with proper feedback to the user when things go wrong.

Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
@olamy
Copy link
Contributor Author

olamy commented Nov 12, 2024

@joakime I have simplified and so do not need anymore this tmp directory to delete.

@olamy olamy merged commit 24a4597 into master Nov 13, 2024
12 checks passed
@olamy olamy deleted the jetty-12-ee11 branch November 13, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants