Fix use of disallowed internal std library functions in go 1.23 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnodel
deleted the
105-link-githubcomarnodelgoluaruntime-invalid-reference-to-runtimeint64hash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used the following internal functions from the
runtimestandard library package to compute the hash of a GoluaValue//go:linkname goRuntimeInt64Hash runtime.int64Hash //go:noescape func
goRuntimeInt64Hash(i uint64, seed uintptr) uintptr
//go:linkname goRuntimeEfaceHash runtime.efaceHash //go:noescape func
goRuntimeEfaceHash(i interface{}, seed uintptr) uintptr
But since go 1.23 it is no longer allowed to use //go.linkname to refer to
internal symbols in the standard library (see https://tip.golang.org/doc/go1.23#linker).
This means the above is no longer possible.