Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Error Categorisation Logic #4054

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Fix Error Categorisation Logic #4054

merged 4 commits into from
Nov 25, 2024

Conversation

d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented Nov 22, 2024

The scheduler metrics error categorization was not correct. Specifically:

  • jobErrorsByQueue had a label of Pool which was being incorrectly populated with the Executor value
  • jobErrorsByNode was defined but no metrics were ever recorded.

I've fixed both these issues and added a test

@d80tb7 d80tb7 merged commit 39ea0d3 into master Nov 25, 2024
27 of 28 checks passed
@d80tb7 d80tb7 deleted the f/chrisma/node-errors branch November 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesMurkin JamesMurkin JamesMurkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d80tb7 @JamesMurkin