feat: Add logic for queue controller (Part 1) #346
+1,443
−367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sovietaced
force-pushed
the
queue-controller
branch
2 times, most recently
from
ad25360 to
2bac68c
Compare
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
force-pushed
the
queue-controller
branch
from
801bf51 to
8ba5462
Compare
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
commented
Jan 2, 2025
| ) | ||
|
|
||
| // GetObject will get the object from Kubernetes and return if it is missing or an error. | ||
| func GetObject( |
There was a problem hiding this comment.
Moved this so it could be used by other controller logic
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
force-pushed
the
queue-controller
branch
from
d5df76e to
8965ff9
Compare
Sovietaced
commented
Jan 2, 2025
| setupLog.Error(err, "unable to create controller", "controller", "Queue") | ||
| os.Exit(1) | ||
| } | ||
| //if err = (&corecontrollers.QueueReconciler{ |
There was a problem hiding this comment.
Commenting this out for now to avoid any NPEs in this intermediate state where the queue client can be nil.
Sovietaced
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This pull request implements logic for the queue controller but does not wire it up to actually work yet. The queue controller reconciles queue custom resources against the Armada server so that queues can be managed by GitOps instead of using
armadactlmanually.I wanted to break this pull request out since I think the wiring part will be where most of the discussion and back/forth will be. The next pull request will include code for how to configure the API connection to the Armada API server and how to load that config through helm charts.
As part of this pull request I re arranged some of the common helpers so they could be used by the queue reconciling logic too.
Related to #323
Please select the type of change your PR introduces:
How Has This Been Tested?
This pull request includes unit tests and has been tested against our production environment.
Checklist: