-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hashing to secp256k1
#863
Open
skaunov
wants to merge
20
commits into
arkworks-rs:master
Choose a base branch
from
skaunov:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaunov
changed the title
Add hashing to Nov 7, 2024
secp256k1_XMD:SHA-256_SSWU_RO_
missing the isogenous generatorsecp256k1
skaunov
requested review from
z-tech,
weikengchen and
tyshko-rostyslav
and removed request for
a team
November 7, 2024 05:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is draft since I need a hint! When hashing the lib checks that the isogenous generator maps correctly onto the target curve generator. The problem is I couldn't find the relevant generator for RFC9380 yet (via a reference, or computationally). I found out that there's a path via the isogeny kernel, but I wonder if somebody could suggest a simpler way to obtain that to continue with this.
Description
Adds hashing to the <curves/secp256k1>.
closes: none - just a development
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
v0.5
will be merged intomaster
Pending
section inCHANGELOG.md
: feels like a bad idea untilv0.5
is merged intomaster
Files changed
in the GitHub PR explorer