Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hash-to-curve around digest::XofReader trait #643

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Refactor hash-to-curve around digest::XofReader trait #643

wants to merge 47 commits into from

Commits on Jun 11, 2023

  1. Avoid unused subdirectories

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    d652bf3 View commit details
    Browse the repository at this point in the history

  2. Pseduo-remove MapToCurve::new, renamed to test_parameters 

    MapToCurve::new seemingly originates from a more runtime oriented
elliptic curve crate:
https://github.com/armfazh/redox-ecc/blob/master/src/ellipticcurve.rs#L36

Arguably test_parameters should be inherent methods, invoked by whoever
defined the parameters, but maybe not?  I left the trait method for now.
    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    c17b654 View commit details
    Browse the repository at this point in the history

  3. Update ec/src/hashing/curve_maps/wb.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    2 people authored and ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    b4633c9 View commit details
    Browse the repository at this point in the history

  4. Update ec/src/hashing/curve_maps/swu.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    2 people authored and ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    6c1a355 View commit details
    Browse the repository at this point in the history

  5. Update ec/src/hashing/map_to_curve_hasher.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    2 people authored and ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    d211861 View commit details
    Browse the repository at this point in the history

  6. Update ec/src/hashing/curve_maps/swu.rs 

    Co-authored-by: Pratyush Mishra <[email protected]>
    @burdges @Pratyush
    2 people authored and ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    53d9cda View commit details
    Browse the repository at this point in the history

  7. Two more renames

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    10d2d6d View commit details
    Browse the repository at this point in the history

  8. make rustfmt happier

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    6d8fd58 View commit details
    Browse the repository at this point in the history

  9. Again rustfmt

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    c7ffca1 View commit details
    Browse the repository at this point in the history

  10. rustfmt is wrong on this one but whatever 

    rustfmt is wrong that f()? should be preferred over f() ?, as errors paths should often be highlighted, but nobody merged that fix yet, so whatever. 
rust-lang/rustfmt#5595
    @burdges
    burdges authored and ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    80f889b View commit details
    Browse the repository at this point in the history

  11. Z_pad without Vec

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    5d149da View commit details
    Browse the repository at this point in the history

  12. inherent method for construct_dst_prime

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    b3eaa74 View commit details
    Browse the repository at this point in the history

  13. Use update directly for ExpanderXoF

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    65f2229 View commit details
    Browse the repository at this point in the history

  14. More idiomatic lib_str

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    90ed308 View commit details
    Browse the repository at this point in the history

  15. DST abstraction

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    f311cc2 View commit details
    Browse the repository at this point in the history

  16. Test that DST works

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    6c8eeff View commit details
    Browse the repository at this point in the history

  17. Remove inherent method in favor of DST

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    343a8b7 View commit details
    Browse the repository at this point in the history

  18. defalt instead of clone

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    e9ce287 View commit details
    Browse the repository at this point in the history

  19. Default insead of Clone

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    23f1772 View commit details
    Browse the repository at this point in the history

  20. Field::from_base_prime_field_elems takes Iterator, not slice.

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    15fc1a5 View commit details
    Browse the repository at this point in the history

  21. use const len in hash_to_field

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    f19976e View commit details
    Browse the repository at this point in the history

  22. Ugh Vec -> Vec here was just stupid

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    99299ce View commit details
    Browse the repository at this point in the history

  23. Kill DynDigest

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    20b4111 View commit details
    Browse the repository at this point in the history

  24. Idiomatic const

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    fd0d50f View commit details
    Browse the repository at this point in the history

  25. semi-merge dst_prime

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    727daaf View commit details
    Browse the repository at this point in the history

  26. FixedOutputReset instead of FixedOutput

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    e0f1ab7 View commit details
    Browse the repository at this point in the history

  27. More double Vec stupidity

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    25af4a6 View commit details
    Browse the repository at this point in the history

  28. Initial XofReader based hash_to_field

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    9982b4d View commit details
    Browse the repository at this point in the history

  29. Expose DST

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    5fa83ef View commit details
    Browse the repository at this point in the history

  30. user reset

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    6573052 View commit details
    Browse the repository at this point in the history

  31. Switch to XofReader 

    Interface remains shit, but it becomes fixable now.
    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    818e821 View commit details
    Browse the repository at this point in the history

  32. Sergey complained. lol

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    a1fdce4 View commit details
    Browse the repository at this point in the history

  33. Switch to fn interface

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    a697434 View commit details
    Browse the repository at this point in the history

  34. Compute block_size and use Update

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    25c93fb View commit details
    Browse the repository at this point in the history

  35. Expose more

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    75a00a0 View commit details
    Browse the repository at this point in the history

  36. Add Expander trait. 

    I'd prefer free fns here myself, but likely everyone else prefers some
trait, and it does make the interface more consistent.
    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    567cf5f View commit details
    Browse the repository at this point in the history

  37. Oops, this would never have worked. Artifact of bad test vectors.

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    9d6148d View commit details
    Browse the repository at this point in the history

  38. expand_for_field

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    2e4629d View commit details
    Browse the repository at this point in the history

  39. PanicExpander is unecessary

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    3f4c137 View commit details
    Browse the repository at this point in the history

  40. Attempt at new hash-to-curve traits

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    22858b2 View commit details
    Browse the repository at this point in the history

  41. cargo check psses, ugly hack around const-generic being broken

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    db6feb0 View commit details
    Browse the repository at this point in the history

  42. Remove curve_maps:: everywhere to shrink later diffs

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    b8dda7c View commit details
    Browse the repository at this point in the history

  43. Allow slice DSTs

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    ba26f3c View commit details
    Browse the repository at this point in the history

  44. Move sec_param from type or value level, given const generics does not 

    work quite right yet
    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    db8fea5 View commit details
    Browse the repository at this point in the history

  45. Fix ark_ec tests

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    7705b72 View commit details
    Browse the repository at this point in the history

  46. Ok don't make DSTs be 'static

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    95cbf11 View commit details
    Browse the repository at this point in the history

  47. Tentative fix to test-curves

    ¨Jeff committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    3d32841 View commit details
    Browse the repository at this point in the history