fix alsa hw params constraints #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current pcm plugin code results in very strange buffer and period size selections if the application sets period size before buffer size. This simple fix corrects that issue. There does not appear to be any clue in the ALSA docs as to why the period size max needs to be so high, but looking at other io plugin examples they all appear to set the max period to at least 1MB and in testing this change always gives sensible values for both period and bufffer sizes.
arkq
approved these changes
Jun 11, 2021
arkq
pushed a commit
that referenced
this pull request
Jun 11, 2021
Current PCM plug-in code results in very strange buffer and period size selections if the application sets period size before buffer size. This simple fix corrects that issue. There does not appear to be any clue in the ALSA docs as to why the period size max needs to be so high, but looking at other IO plug-in examples they all appear to set the max period to at least 1MB and in testing this change always gives sensible values for both period and buffer sizes. Closes #458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating issue #451, I discovered this peculiar oddness with the ioplug hw param handilng. With this change, when an application asks for a period time of 100ms, it is actually given one of that size, no matter whether it sets the buffer size before or after the period. 😄 Hopefully this may even resolve the above mentioned issue !!