Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double notifications if redmine mention sent. #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kporras07
Copy link

Hi,

Thanks for such a great plugin. I'd like to contribute my solution to #28

Any feedback is welcome :)

@hishammalik
Copy link
Member

Thank you for the contribution! However, this goes against the redmine notifications settings as users who are expecting to receive notifications will all of a sudden realize that they are not receiving notifications.

Correct patch would be to add configurations related to email notification settings under user to allow for options like "Only for events when no one is mentioned", etc. See screenshot for the notification settings:

Screenshot 2020-07-24 11 55 56

@kporras07
Copy link
Author

@hishammalik thanks for your feedback. I'm kind of new to Ruby and I'm not really getting to fix this as suggested.

I've found that the options are defined in User::MAIL_NOTIFICATION_OPTIONS constant; but I haven't found how to override that constant in a patch. I'd be happy to update the PR if you can point me to how to override the constant in a patch.

@unknown2222
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants