Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

User groups #166

Merged
merged 6 commits into from
Feb 4, 2021
Merged

User groups #166

merged 6 commits into from
Feb 4, 2021

Conversation

KyleMaas
Copy link
Collaborator

@KyleMaas KyleMaas commented Feb 3, 2021

Adds the ability to create, delete, and manage user groups. These allow you to quickly look at messages from only certain users.

Fixes #165. Thinking this might be the missing piece of #32 as well, but I'll leave that up to you.

@arj03
Copy link
Owner

arj03 commented Feb 3, 2021

Havn't looked yet, but I'm really looking forward to giving this a spin. I'm getting close to fixing friends, but it still needs another round. The good thing is that I might have found out what the problem with the original profile/about messages was so I'm thinking of maybe going back to that if I can figure out why this is slower in the browser.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 3, 2021

Cool. If we could do that, then maybe we could drop ssb-suggest in favor of the local index so we don't have to worry about ssbc/ssb-suggest#10

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 3, 2021

I will note, too, that as someone who has traditionally eschewed social media, I found this feature to be unexpectedly helpful. It'd be great if we could figure out a way to persist this to SSB once we've run this for a bit and had a chance to shake the bugs out of it.

@arj03
Copy link
Owner

arj03 commented Feb 3, 2021

This has a minor conflict now. Can you fix?

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 3, 2021

Sure. Give me a few minutes to finish up the blocked user stuff.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 3, 2021

That should do it.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 4, 2021

Fixed merge conflicts again.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 4, 2021

Were you thinking trying to get this into 4.2.0 as well, or waiting until later?

@arj03
Copy link
Owner

arj03 commented Feb 4, 2021

A bit undecided on that. Was really busy with the ssb-friends and about stuff. I think it can go in. Will have a proper look today.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 4, 2021

Okay. I'll keep trying to keep it conflict-free, then.

css/main.css Outdated
@@ -287,6 +287,31 @@ body, html {
background-color: #6c6;
}

<<<<<<< HEAD
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in new revision. Thanks

@arj03
Copy link
Owner

arj03 commented Feb 4, 2021

Was reading the diff, seems like a self-contained chunk, so I'm looking forward to merging, but before I do I have a question. It seems like groups can also contain channels and not only feeds?

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 4, 2021

No, user groups only contain users. But I put the group-making interface onto the Channels tab, since we don't really have the screen space for a "Groups" tab and the functionality of viewing a channel or a group seemed similar enough.

@arj03
Copy link
Owner

arj03 commented Feb 4, 2021

Ah I see. Thanks. Will merge this tonight.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 4, 2021

I'll be unavailable for the next several hours, so please feel free to make whatever changes to this you feel are necessary.

@arj03 arj03 merged commit 57a54c4 into arj03:master Feb 4, 2021
@arj03
Copy link
Owner

arj03 commented Feb 4, 2021

OMG. This is amazing! I've wanted this feature for so long...

@arj03
Copy link
Owner

arj03 commented Feb 4, 2021

We really need to make room for this somewhere in the top menu. This is so damn cool 🚀

I tried changing notifications to 🔔. And then moving it maybe to the right next to the other icon should leave enough room. Also at first I was expecting this to be on the public page as a filter at the top. But I think with a menu item that makes maybe more sense? I really like that you can see the members directly. I made a tiny css tweak, all of this is merged into the friends-about PR. Feel free to create a fork of that to make some tweaks.

@KyleMaas KyleMaas deleted the user-groups branch February 5, 2021 00:08
@KyleMaas KyleMaas mentioned this pull request Feb 5, 2021
@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 5, 2021

Here 'ya go:

#177

It does not add filters for user groups to the Public tab. We could maybe do that at a future date, but I'd like to have filters expand/collapse first because that filter box is already using valuable screen space and pushing down the messages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User groups
2 participants