-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
Havn't looked yet, but I'm really looking forward to giving this a spin. I'm getting close to fixing friends, but it still needs another round. The good thing is that I might have found out what the problem with the original profile/about messages was so I'm thinking of maybe going back to that if I can figure out why this is slower in the browser. |
Cool. If we could do that, then maybe we could drop ssb-suggest in favor of the local index so we don't have to worry about ssbc/ssb-suggest#10 |
I will note, too, that as someone who has traditionally eschewed social media, I found this feature to be unexpectedly helpful. It'd be great if we could figure out a way to persist this to SSB once we've run this for a bit and had a chance to shake the bugs out of it. |
This has a minor conflict now. Can you fix? |
Sure. Give me a few minutes to finish up the blocked user stuff. |
That should do it. |
Fixed merge conflicts again. |
Were you thinking trying to get this into 4.2.0 as well, or waiting until later? |
A bit undecided on that. Was really busy with the ssb-friends and about stuff. I think it can go in. Will have a proper look today. |
Okay. I'll keep trying to keep it conflict-free, then. |
css/main.css
Outdated
@@ -287,6 +287,31 @@ body, html { | |||
background-color: #6c6; | |||
} | |||
|
|||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in new revision. Thanks
Was reading the diff, seems like a self-contained chunk, so I'm looking forward to merging, but before I do I have a question. It seems like groups can also contain channels and not only feeds? |
No, user groups only contain users. But I put the group-making interface onto the Channels tab, since we don't really have the screen space for a "Groups" tab and the functionality of viewing a channel or a group seemed similar enough. |
Ah I see. Thanks. Will merge this tonight. |
I'll be unavailable for the next several hours, so please feel free to make whatever changes to this you feel are necessary. |
OMG. This is amazing! I've wanted this feature for so long... |
We really need to make room for this somewhere in the top menu. This is so damn cool 🚀 I tried changing notifications to 🔔. And then moving it maybe to the right next to the other icon should leave enough room. Also at first I was expecting this to be on the public page as a filter at the top. But I think with a menu item that makes maybe more sense? I really like that you can see the members directly. I made a tiny css tweak, all of this is merged into the friends-about PR. Feel free to create a fork of that to make some tweaks. |
Here 'ya go: It does not add filters for user groups to the Public tab. We could maybe do that at a future date, but I'd like to have filters expand/collapse first because that filter box is already using valuable screen space and pushing down the messages. |
Adds the ability to create, delete, and manage user groups. These allow you to quickly look at messages from only certain users.
Fixes #165. Thinking this might be the missing piece of #32 as well, but I'll leave that up to you.