Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update convertString to handle values with double quotes #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update convertString to handle values with double quotes #30

wants to merge 2 commits into from

Conversation

arithmetric
Copy link
Owner

Currently the convertString handler builds a string like key="value". However value can contain double quote characters, which can cause problems with some parsers.

This PR changes convertString to replace all double quotes with another character, either by default a single quote or another character specified through configuration.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4b9ced9 on fix_cloudwatch_logs_with_quotes into 9ac3c6e on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arithmetric @coveralls