-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts #4853
Open
ctyrider
wants to merge
5
commits into
aristanetworks:devel
Choose a base branch
from
ctyrider:issue4848
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4853
# Activate the virtual environment
source test-avd-pr-4853/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ctyrider/avd.git@issue4848#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ctyrider/avd.git#/ansible_collections/arista/avd/,issue4848 --force
# Optional: Install AVD examples
cd test-avd-pr-4853
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
labels
Jan 3, 2025
1 task
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Jan 7, 2025
ctyrider
changed the title
Feat (eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts
Feat(eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts
Jan 7, 2025
Ready to merge |
gmuloc
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for this PR - couple of comments
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-connectivity.j2
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for "icmp echo size ..." CLI syntax, under Monitor Connectivity hosts:
Related Issue(s)
Fixes #4848
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
New icmp_echo_size variable in eos_cli_config_gen:
How to test
Molecule test pending
Checklist
User Checklist
Repository Checklist