Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(cv_deploy): Ensure lossrate for cv_pathfinder metadata is a float #4852

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Ensure lossrate for cv_pathfinder metadata is a float

Component(s) name

arista.avd.cv_workflow
arista.avd.cv_deploy

Proposed changes

  • Recent changes made the metadata follow the schema 1:1, where the lossrate is a string.
  • This now means we have to convert the lossrate to a float before sending it to CloudVision.

How to test

Amit will test manually.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Jan 3, 2025

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4852
# Activate the virtual environment
source test-avd-pr-4852/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/cv_deploy/ensure-limits-are-floats#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/cv_deploy/ensure-limits-are-floats --force
# Optional: Install AVD examples
cd test-avd-pr-4852
ansible-playbook arista.avd.install_examples

@gmuloc gmuloc requested a review from amit-arista January 3, 2025 16:10
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - waiting for @amit-arista to confirm it works on cvaas

@gmuloc gmuloc requested a review from a team January 3, 2025 16:21
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jan 3, 2025
@ClausHolbechArista
Copy link
Contributor Author

Tested successfully by Amit.

@ClausHolbechArista ClausHolbechArista merged commit 7904f44 into aristanetworks:devel Jan 4, 2025
43 checks passed
@gmuloc gmuloc removed the request for review from amit-arista January 6, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix(cv_deploy)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants