-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Added support for fips_restrictions under management security #4845
base: devel
Are you sure you want to change the base?
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4845
# Activate the virtual environment
source test-avd-pr-4845/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/KrasenKolev/avd.git@devel#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/KrasenKolev/avd.git#/ansible_collections/arista/avd/,devel --force
# Optional: Install AVD examples
cd test-avd-pr-4845
ansible-playbook arista.avd.install_examples |
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/management-security.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/management_security.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/management-security.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-security.j2
Outdated
Show resolved
Hide resolved
…anagement_security.schema.yml Co-authored-by: Mahesh Kumar <[email protected]>
… now include fips-restrictions
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-security.j2
Outdated
Show resolved
Hide resolved
…/management-security.j2 Co-authored-by: Claus Holbech <[email protected]>
You need to pull on your dev machine and then rerun molecule and commit the updates. |
…' when the value is undefined
|
@ClausHolbechArista, I committed the updates after running the molecule, but by mistake I closed the PR, not sure if something more had to be done. |
We need to merge the PR, reopening it |
you need to rerun the molecule for cv-pathfinder example.
So run locally
|
@gmuloc that is correct. I was running only:
which is in the contribution guide. I ran it now and committed the changes |
indeed the contribution guide should probably add some info regarding re-running some other molecule scenario when modifying the documentation template that could impact them (though it can be hard to know in advance without running everything which takes quite a while). @Shivani-gslab can you integrate this to your PR? thanks! |
Change Summary
Add support for fips restrictions under management security -> ssl profile.
Related Issue(s)
Fixes #4760
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
add 'fips restrictions' under management security
How to test
Checklist
User Checklist
Repository Checklist