Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Added support for fips_restrictions under management security #4845

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from

Conversation

KrasenKolev
Copy link

Change Summary

Add support for fips restrictions under management security -> ssl profile. 


Related Issue(s)

Fixes #4760

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

add 'fips restrictions' under management security

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@KrasenKolev KrasenKolev requested review from a team as code owners December 28, 2024 19:29
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4845
# Activate the virtual environment
source test-avd-pr-4845/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/KrasenKolev/avd.git@devel#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/KrasenKolev/avd.git#/ansible_collections/arista/avd/,devel --force
# Optional: Install AVD examples
cd test-avd-pr-4845
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 28, 2024
@MaheshGSLAB MaheshGSLAB changed the title added support for fips_restrictions under management security Feat(eos_cli_config_gen): Added support for fips_restrictions under management security Jan 3, 2025
@ClausHolbechArista
Copy link
Contributor

You need to pull on your dev machine and then rerun molecule and commit the updates.

@KrasenKolev
Copy link
Author

You need to pull on your dev machine and then rerun molecule and commit the updates.

@KrasenKolev KrasenKolev closed this Jan 7, 2025
@KrasenKolev
Copy link
Author

@ClausHolbechArista, I committed the updates after running the molecule, but by mistake I closed the PR, not sure if something more had to be done.

@Vibhu-gslab
Copy link
Contributor

We need to merge the PR, reopening it

@Vibhu-gslab Vibhu-gslab reopened this Jan 7, 2025
@gmuloc
Copy link
Contributor

gmuloc commented Jan 7, 2025

@KrasenKolev

you need to rerun the molecule for cv-pathfinder example.
I tried to update the PR but it seems you are not allowing AVD maintainers to push to your branch PR:

To github.com:KrasenKolev/avd.git
 ! [remote rejected]     KrasenKolev/devel -> KrasenKolev/devel (permission denied)
error: failed to push some refs to 'github.com:KrasenKolev/avd.git'

So run locally

cd ansible_collections/arista/avd
molecule converge -s example-cv-pathfinder -- -f 10

@KrasenKolev
Copy link
Author

KrasenKolev commented Jan 7, 2025

@KrasenKolev

you need to rerun the molecule for cv-pathfinder example. I tried to update the PR but it seems you are not allowing AVD maintainers to push to your branch PR:

To github.com:KrasenKolev/avd.git
 ! [remote rejected]     KrasenKolev/devel -> KrasenKolev/devel (permission denied)
error: failed to push some refs to 'github.com:KrasenKolev/avd.git'

So run locally

cd ansible_collections/arista/avd
molecule converge -s example-cv-pathfinder -- -f 10

@gmuloc that is correct. I was running only:

molecule converge -s eos_cli_config_gen

which is in the contribution guide. I ran it now and committed the changes

@gmuloc
Copy link
Contributor

gmuloc commented Jan 7, 2025

@KrasenKolev
you need to rerun the molecule for cv-pathfinder example. I tried to update the PR but it seems you are not allowing AVD maintainers to push to your branch PR:

To github.com:KrasenKolev/avd.git
 ! [remote rejected]     KrasenKolev/devel -> KrasenKolev/devel (permission denied)
error: failed to push some refs to 'github.com:KrasenKolev/avd.git'

So run locally

cd ansible_collections/arista/avd
molecule converge -s example-cv-pathfinder -- -f 10

@gmuloc that is correct. I was running only:

molecule converge -s eos_cli_config_gen

which is in the contribution guide. I ran it now and committed the changes

indeed the contribution guide should probably add some info regarding re-running some other molecule scenario when modifying the documentation template that could impact them (though it can be hard to know in advance without running everything which takes quite a while).

@Shivani-gslab can you integrate this to your PR? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for fips_restrictions
5 participants