Refactor(eos_cli_config_gen): Add default: default for ip_name_servers[].vrf

[laxmikantchintakindi]

Change Summary

Add default: default for ip_name_servers[].vrf

Related Issue(s)

Fixes #4788

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add default: default for ip_name_servers[].vrf

How to test

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4842
# Activate the virtual environment
source test-avd-pr-4842/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/eos_cli/ip-name-server-vrf-default#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/eos_cli/ip-name-server-vrf-default --force
# Optional: Install AVD examples
cd test-avd-pr-4842
ansible-playbook arista.avd.install_examples

[Shivani-gslab]

In doc template also the default value for vrf should be "default"

{% for name_server in ip_name_servers | arista.avd.default([]) %}
| {{ name_server.ip_address }} | {{ name_server.vrf | arista.avd.default('default') }} | {{ name_server.priority | arista.avd.default('-') }} |
{% endfor %}

Clicked on approve by mistake

[laxmikantchintakindi]

In doc template also the default value for vrf should be "default"

{% for name_server in ip_name_servers | arista.avd.default([]) %} | {{ name_server.ip_address }} | {{ name_server.vrf | arista.avd.default('default') }} | {{ name_server.priority | arista.avd.default('-') }} | {% endfor %}

Done.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[Shivani-gslab]

LGTM!

[ClausHolbechArista]

This is a breaking change since you are changing the generated configuration. I don't think we really need this change. If people want the default VRF to show up in the generated config, they can just give it on input.

[laxmikantchintakindi]

This is a breaking change since you are changing the generated configuration. I don't think we really need this change. If people want the default VRF to show up in the generated config, they can just give it on input.

Okay. Shall I use a variable default only in the template to sort the commands as per EOS and not generate the default word in the output?

[laxmikantchintakindi]

Closing the PR as adding default vrf is not necessary. The vrf key will be required starting from AVD 6.0.0.