Update stp.rb #176
Open
Update stp.rb #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regex match doesn't work when using spanning tree mode rapid-pvst. Match is wrong. Puppet errors with Nil class. Fix is to match hyphen.
|
Can one of the admins verify this patch? |
|
Jenkins, test this please |
|
@nicholas-lawrence Thanks for the PR. Could you provide the EOS version and a sample config line which requires this change? This change may require an EOS version check, if the output being parsed has changed. Thanks. |
|
Hi there, this was doing is on both software versions - I upgraded to see
if it would fix it but to no avail.
Arista DCS-7050SX2-72Q-R
EOS-4.19.5M and EOS-4.19.6.3M
The puppet manifest we use is with hiera - but even if we just used a
simple one calling spanning-tree port fast or bpduguard it would error.
eos_stp_interface { et1:
portfast => enable,
bpduguard => enable,
}
Please let me know what else you need.
Thank you
Nicholas
…On 24 May 2018 at 05:15, Jere Julian ***@***.***> wrote:
@nicholas-lawrence <https://github.com/nicholas-lawrence> Thanks for the
PR. Could you provide the EOS version and a sample config line which
requires this change? This change may require an EOS version check, if the
output being parsed has changed.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Alp0EmlXfagVnXu97bNjJcqq8JC8AylCks5t1jPTgaJpZM4UGsDa>
.
|
|
@eosplus-jenkins and @jerearista when is this fix going to be merged into mainstream? Been waiting on this fix for a while now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex match doesn't work when using spanning tree mode rapid-pvst. Match is wrong.
Puppet errors with Nil class. Fix is to match hyphen.