Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Reorganize public param module #1087

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[wip] Reorganize public param module #1087

wants to merge 6 commits into from

Conversation

winston-h-zhang
Copy link
Contributor

huitseeker and others added 6 commits January 30, 2024 17:04
This adapts to upstream lurk-lang/arecibo#285, which removes the need for separate `ProverKey` and `VerifierKey` instances (the former containing `CommitmentKey` copies) in Public Parameters.

- Implemented structural changes in `nova.rs` for improvements in key handling for the prover and verifier keys, which generated as `OnceCell`,

- Revamped `disk_cache.rs` with added `Arc` imports, elimination of lifetime parameter `'a` from `DiskCache`, modifications of `read` and `write` functions, and updates in the serialization and deserialization steps.
- Altered `public_params` and `supernova_public_params` functions in `mod.rs` to deal more capably with errors and modified various methods and tests to align with the changes in `disk_cache.rs`.
- Removed complete `mem_cache.rs` file, which was unsafe, and unused.

- Moved initialization of `store` to an earlier point in `fibonacci_prove` function and made minor formatting changes in `fibonacci.rs`.
…dependency

- Removed `Abomonation` trait and `PrimeField` imports from `multiframe.rs`, also simplified the `NonUniformCircuit` access in the same file.
- Removed `Abomonation` trait bounds from the `circuit_cache_key` functions in `supernova.rs`.
- Refactored `Instance<>` struct in `instance.rs`, removing the usage of `Abomonation` and `PhantomData`, and eliminated need for lifetime declaration `'a`.
- Enhanced `open()` method in `instance.rs` to include metadata comparison to prevent instance mismatches.
…on bounds

- Improved `supernova.rs` by using `OnceCell` to store `ProverKey` and `VerifierKey` and updating related methods,
- removed uneeded Abomonation bounds in a few places.
…rc usage

- reduced complexity by removing `std::sync::Arc` in `src/public_parameters/disk_cache.rs`.
- Modified `read` and `write` functions in `DiskCache` to work directly with `PublicParams`.
@winston-h-zhang winston-h-zhang changed the base branch from main to refresh_public_params January 31, 2024 19:56
Base automatically changed from refresh_public_params to main January 31, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants