Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add preallocated and indexed MSMs #13

Closed
wants to merge 11 commits into from
Closed

add preallocated and indexed MSMs #13

wants to merge 11 commits into from

Conversation

winston-h-zhang
Copy link
Contributor

This PR introduces two API changes to sppark's MSM in preparation for future developments.

  1. We add an API to preallocate points, passing back a reference to it in a MSMContext<'_>
  2. We add an API to handle variable sized, indexed MSMs. This is because as we fiddle around with optimizing our witness generation, there's a good chance the witness will not be stored contiguously, or even in a vector anymore. In these cases, this new indexed API will allow us to compute an MSM will more flexible data structures.

This was referenced Feb 8, 2024
Closed
Closed
Closed
Closed
@winston-h-zhang winston-h-zhang marked this pull request as ready for review February 9, 2024 21:46
@huitseeker huitseeker mentioned this pull request Feb 19, 2024
Closed
@winston-h-zhang winston-h-zhang mentioned this pull request Feb 19, 2024
Closed
@huitseeker
Copy link
Contributor

Closing in favor of argumentcomputer/arecibo#374

@huitseeker huitseeker closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker Awaiting requested review from huitseeker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winston-h-zhang @huitseeker