-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move to the Ingonyama MSM #374
Open
winston-h-zhang
wants to merge
5
commits into
dev
Choose a base branch
from
ingonyama-msm
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,6 @@ use crate::{ | |
use digest::{ExtendableOutput, Update}; | ||
use ff::{FromUniformBytes, PrimeField}; | ||
use group::{cofactor::CofactorCurveAffine, Curve, Group as AnotherGroup}; | ||
#[cfg(any(target_arch = "x86_64", target_arch = "aarch64"))] | ||
use grumpkin_msm::{bn256 as bn256_msm, grumpkin as grumpkin_msm}; | ||
// Remove this when https://github.com/zcash/pasta_curves/issues/41 resolves | ||
use halo2curves::{bn256::G2Affine, CurveAffine, CurveExt}; | ||
use num_bigint::BigInt; | ||
|
@@ -35,6 +33,32 @@ pub mod grumpkin { | |
}; | ||
} | ||
|
||
#[cfg(any(target_arch = "x86_64", target_arch = "aarch64"))] | ||
fn bn256_msm(points: &[bn256::Affine], scalars: &[bn256::Scalar]) -> bn256::Point { | ||
cfg_if::cfg_if! { | ||
if #[cfg(feature = "cuda")] { | ||
let stream = ingonyama_grumpkin_msm::Config::new(); | ||
let cfg = ingonyama_grumpkin_msm::default_config(&stream.stream); | ||
ingonyama_grumpkin_msm::bn256_msm(&points, &scalars, &cfg) | ||
} else { | ||
grumpkin_msm::bn256(points, scalars) | ||
} | ||
} | ||
} | ||
|
||
#[cfg(any(target_arch = "x86_64", target_arch = "aarch64"))] | ||
fn grumpkin_msm(points: &[grumpkin::Affine], scalars: &[grumpkin::Scalar]) -> grumpkin::Point { | ||
cfg_if::cfg_if! { | ||
if #[cfg(feature = "cuda")] { | ||
let stream = ingonyama_grumpkin_msm::Config::new(); | ||
let cfg = ingonyama_grumpkin_msm::default_config(&stream.stream); | ||
Comment on lines
+53
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we make this a |
||
ingonyama_grumpkin_msm::grumpkin_msm(&points, &scalars, &cfg) | ||
} else { | ||
grumpkin_msm::grumpkin(points, scalars) | ||
} | ||
} | ||
} | ||
|
||
#[cfg(any(target_arch = "x86_64", target_arch = "aarch64"))] | ||
impl_traits!( | ||
bn256, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make this a
static
to not create it on every call?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this, but ran into issues like
Dmytro mentioned that the first stream creation will have some delay, but each time after that, the Icicle/CUDA runtime will be able to reuse them with little overhead.