Fix include directory when installing #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifing the path twice would cause CMake to think that the include
files were being installed to "{PREFIX}/DESTINATION", which would cause
package inclusion to fail.
|
@JetbladeDevsStuff : Thanks a lot for this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the include directory when installing the package was specified twice in the call to
install. This caused CMake to believe that the include files were being moved to both${CMAKE_INSTALL_INCLUDEDIR}and the non-existent pathDESTINATION. When another package then tried to use argtable3 by callingfind_package(argtable3), the inclusion would fail because CMake would realize that this path does not exist.