Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added brand directory #1195

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Conversation

soniya-malviy
Copy link
Contributor

Fixed issue #1193

Added brand directory

Before PR:
Image 14-06-24 at 1 47 PM

After PR:
Image 14-06-24 at 3 29 PM

  • [No ] Bug fix

  • [ yes] Feature enhancement

  • [ no] Documentation update
    -[yes] issue solved under Gssoc'24

  • [ yes] I have performed a self-review of my code

  • [ yes] I have read and followed the Contribution Guidelines.

  • [yes ] I have tested the changes thoroughly before submitting this pull request.

  • [ yes] I have provided relevant issue numbers, screenshots, and videos after making the changes.

  • [yes ] I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flipkart-clone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 8:24am

Copy link
Contributor Author

@soniya-malviy soniya-malviy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment

@arghadipmanna101
Copy link
Owner

There have some conflict issue. check it once

@soniya-malviy
Copy link
Contributor Author

soniya-malviy commented Jun 15, 2024

I will solve this conflict in new PR @arghadipmanna101 . Is it okay?
Or now conflict is solved?

@arghadipmanna101 arghadipmanna101 merged commit af91751 into arghadipmanna101:main Jun 16, 2024
2 checks passed
@arghadipmanna101 arghadipmanna101 added level2 An midium issue. gssoc Fun with GSSOC'24 labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Fun with GSSOC'24 level2 An midium issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants