Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: call start() after NDEdgePlugin object is created for plugin to work for ADCore >= 2.5, don't process plugin if input NDArray dimension > 2 (i.e. for Color modes) #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apanna
Copy link

@apanna apanna commented Nov 16, 2016

This commit fixes 2 minor issues:

  1. The plugin is missing the start() method which is called after the object is created. This is required for ADCore >= 2.5
  2. If the input NDArray dimension > 2 ( e.g for Color Modes) then the ioc crashes, so don't process the plugin for such cases.

I tested this on windows-x64-static, areaDetector-2-5, and opencv-2.4.13

…work for ADCore >= 2.5, don't process plugin if input NDArray dimension > 2 (i.e. for Color modes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant