feat: Use Arduino CLI v1.1.1 #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_{version}_proto.zip`
- Use the CLI release proto.zip to get proto files for production versions of CLI
- Extract the proto files from repo if CLI version is declared as `commitsh` or version is 1.1.0
See arduino/arduino-cli#2761
giacomocusinato
added
type: enhancement
davegarthsimpson
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
v1.1.1arduino_cli_{version}_proto.zipto generate CLI binding for official releasesChange description
Since arduino/arduino-cli#2673 google profile have been removed from source so the generation script is now fetching proto files from the
arduino_cli_{version}_proto.zipfile generated for every release as it includes the google proto files, see arduino/arduino-cli#2761Fetching protos from source is still used if a specific
commitshis provided or is CLI version is 1.1.0, see arduino/arduino-cli#2755In this case, google proto are fetched separately from arduino_cli_1.1.1_proto.zip and copied to the source folder.
Other information
Reviewer checklist