Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a more helpful message when a 'signature expired' error happens. #2750

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 8, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Some users reported spurious "signature expired" errors. After some investigation, we found that all of them had the wrong system date set on their machine, with a date set in the past. Even if the error says that the signature is "expired", it's a signature that is not yet valid (it will be in the future).

This PR change the error message, and prompt the user to check if the system clock is set correctly, hopefully leading to a self resolution of the problem.

What is the current behavior?

The error message is signature expired.

What is the new behavior?

The error message is signature expired: is your system clock set correctly?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Supersedes #2744

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (49c154a) to head (b4c7c5a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
- Coverage   67.65%   67.55%   -0.10%     
==========================================
  Files         237      237              
  Lines       22356    22358       +2     
==========================================
- Hits        15126    15105      -21     
- Misses       6036     6063      +27     
+ Partials     1194     1190       -4     
Flag Coverage Δ
unit 67.55% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 8, 2024
@cmaglie cmaglie added this to the Arduino CLI v1.1.1 milestone Nov 8, 2024
@cmaglie cmaglie merged commit 5fc8845 into arduino:master Nov 11, 2024
98 checks passed
@cmaglie cmaglie deleted the gpg_signature_in_the_future_2 branch November 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants