Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In compile command try to release the package manager lock ASAP #2741

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 30, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This PR fixes a concurrency problem in Compile. When a compile is run, the function will keep the Boards Manager locked for the duration of the compile. This prevents another compile from running in parallel.
This is mostly theoretical since the Arduino IDE does not allow starting two compilations together. BTW, there is another scenario that could be impacted: when the Arduino IDE starts the language server, the language server is required to run a bootstrap compilation in the background, and this compilation may prevent the user from compiling for some seconds.

What is the current behavior?

The package manager is kept locked during the whole compilation.

What is the new behavior?

The package manager is released once all information for compiling is gathered. The compilation then may run without locking the package manager.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (7ee4cf7) to head (6cff889).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
- Coverage   67.62%   67.54%   -0.08%     
==========================================
  Files         237      237              
  Lines       22354    22362       +8     
==========================================
- Hits        15116    15104      -12     
- Misses       6048     6066      +18     
- Partials     1190     1192       +2     
Flag Coverage Δ
unit 67.54% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cmaglie cmaglie self-assigned this Oct 30, 2024
@cmaglie cmaglie added type: enhancement Proposed improvement priority: high Resolution is a high priority topic: code Related to content of the project itself labels Oct 30, 2024
@cmaglie cmaglie marked this pull request as ready for review November 21, 2024 15:57
@cmaglie cmaglie added this to the Arduino CLI v1.1.1 milestone Nov 21, 2024
@cmaglie cmaglie merged commit ca4a4ec into arduino:master Nov 21, 2024
98 checks passed
@cmaglie cmaglie deleted the compile_multithreading branch November 21, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Resolution is a high priority topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants