feat: allow boards to change debug support via FQBN options #2436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
"debug.executable" must be present AND non-empty for debugging to be supported, allowing board overrides. Also, use the same logic in the details view and in the actual debug command implementation.
What is the current behavior?
Debug support is enabled if any of the
txt
files define a key nameddebug.executable
, regardless of its contents, preventing overrides by board and/or menu optionsWhat is the new behavior?
"debug.executable" must be present AND non-empty for debugging to be supported, allowing board overrides. Also, use the same logic in the details view and in the actual debug command implementation.
Does this PR introduce a breaking change, and is titled accordingly?
No, it is backwards compatible (all cores using debug define the key to a valid string, cores without debug never define the key).
Other information
Tested with Arduino Nano ESP32 package.
Original
platform.txt
already contains:Lines added to
boards.txt
:arduino-cli board details -b arduino-git:esp32:nano_nora --format json
does not includedebugging_supported
key.arduino-cli board details -b arduino-git:esp32:nano_nora:USBMode=hwcdc --format json
includes"debugging_supported": true
.