Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed comment #2420

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

alessio-perugini
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Remove a comment in the codebase introduced after a refactoring. The suggested piece of code is no longer needed as we checksum is done when we extract the zip.

@alessio-perugini alessio-perugini self-assigned this Nov 14, 2023
@alessio-perugini alessio-perugini added the type: enhancement Proposed improvement label Nov 14, 2023
@alessio-perugini alessio-perugini added this to the Arduino CLI v0.36.0 milestone Nov 14, 2023
@alessio-perugini alessio-perugini marked this pull request as ready for review November 14, 2023 10:35
@alessio-perugini alessio-perugini changed the title Remove no longer need comment Remove no longer needed comment Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9028b9) 67.17% compared to head (c19b983) 67.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
- Coverage   67.17%   67.16%   -0.02%     
==========================================
  Files         210      210              
  Lines       20534    20534              
==========================================
- Hits        13794    13791       -3     
- Misses       5601     5603       +2     
- Partials     1139     1140       +1     
Flag Coverage Δ
unit 67.16% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini merged commit 7a14663 into master Nov 14, 2023
221 of 223 checks passed
@alessio-perugini alessio-perugini deleted the remove-todo-comment branch November 14, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants