-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added programmer.default
directive to set a default programmer for a board.
#2416
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2416 +/- ##
==========================================
+ Coverage 67.15% 67.17% +0.02%
==========================================
Files 210 210
Lines 20523 20543 +20
==========================================
+ Hits 13782 13800 +18
- Misses 5602 5603 +1
- Partials 1139 1140 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. I would only add a simple test, to avoid breaking in the future
…a board. (#2416) * Updated gRPC API * Implemented default programmer for boards * Added default programmer in board details CLI command * Implemented default programmer functionality in CLI * Added docs
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Adds the
programmer.default
directive to the boards.txt to allow developers to set a default programmer for specific boards. This may turn out useful for boards having an on-board programmer/debugger.What is the current behavior?
All commands requiring a programmer will fail if no programmer is specified.
What is the new behavior?
The same command may not fail if a default programmer is specified in the board's platform.
Does this PR introduce a breaking change, and is titled accordingly?
Other information