-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug: Allow type-specification of JSON output for cortex-debug #2393
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
+ Coverage 64.48% 64.51% +0.03%
==========================================
Files 207 207
Lines 19592 19630 +38
==========================================
+ Hits 12633 12665 +32
- Misses 5867 5871 +4
- Partials 1092 1094 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Will this work with arrays? If yes, please update the example in the PR description. Thanks! I am going to use this version downstream: arduino/vscode-arduino-tools#41. |
I've upgraded the conversion process, now it can:
This change should make it possible to build any JSON from properties. |
* debug: Allow type-specification of JSON output for cortex-debug * Improved JSON properties generation
@kittaakos I've cherrypicked this PR in the |
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
In the cortex-debug section of the debug info, all the values are converted by default to a string in the resulting JSON.
Now, If another type is needed, the value can be prefixed with the tags
[boolean]
,[number]
, or[object]
to force a specific type in the JSON, for example:will result in the following JSON:
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information