-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use feedback/result structs in cli commands instead of rpc ones #2389
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2389 +/- ##
==========================================
+ Coverage 64.48% 64.96% +0.48%
==========================================
Files 207 207
Lines 19593 20211 +618
==========================================
+ Hits 12634 13130 +496
- Misses 5867 5966 +99
- Partials 1092 1115 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
c28cb14
to
50afb30
Compare
50afb30
to
aed7a94
Compare
aed7a94
to
a16ba4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've left some nitpicks here and there.
- I don't like the enumeration handling, I've left some suggestions, but I'm not sure let's chat about it next week
- Great work on the unit-testing 👍🏼
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
IT add a layer of mappers used only in the cli output of ours command and subcommand
What is the current behavior?
We are currently returning/using the rpc structs which isn't ideal for 2 reasons:
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information