-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debugger: some improvements in configuration handling #2364
Conversation
1463405
to
a36dff0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, Thanks cris
Co-authored-by: Umberto Baldi <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2364 +/- ##
=======================================
Coverage 62.92% 62.92%
=======================================
Files 203 203
Lines 19243 19243
=======================================
Hits 12108 12108
Misses 6075 6075
Partials 1060 1060
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Added some small fix in how the debugger configuration is handled:
debug.server.openocd.scripts.N
.debug.server.openocd.script
directive is ignored if is together with thedebug.server.openocd.scripts.N
.What is the current behavior?
debug.server.openocd.scripts.N
sequence was truncated at the first non-consecutive item.script
andscripts
were concatenated in the resulting config.What is the new behavior?
debug.server.openocd.scripts.N
sequence is not truncated even if the items are non-consecutive.scipt
andscripts
are mutually-exclusive in the config with priority given toscripts
.Does this PR introduce a breaking change, and is titled accordingly?
Other information