[breaking] Removed gRPC 'debug' service in favor of 'commands' service #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
requested review from
alessio-perugini,
umbynos,
kittaakos and
MatteoPologruto
cmaglie
added
type: enhancement
cmaglie
force-pushed
the
remove_grpc_debug_service
branch
2 times, most recently
from
81e09fd to
49a0db4
Compare
cmaglie
force-pushed
the
remove_grpc_debug_service
branch
from
49a0db4 to
1a9dc04
Compare
alessio-perugini
approved these changes
Sep 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2349 +/- ##
==========================================
+ Coverage 63.04% 63.12% +0.08%
==========================================
Files 201 201
Lines 19259 19255 -4
==========================================
+ Hits 12141 12155 +14
+ Misses 6064 6051 -13
+ Partials 1054 1049 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kittaakos
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
The gRPC service
cc.arduino.cli.debug.v1has been removed and all gRPC messages and rpc calls have been moved tocc.arduino.cli.commands.v1.The gRPC message
DebugConfigRequesthas been renamed to the properGetDebugConfigRequest.All the generated API has been updated as well.
What is the current behavior?
No changes.
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Yes
Other information