[skip-changelog] Use LoadSketch in upload function and return rpc.Port in GetPort
#2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
cmaglie
approved these changes
Sep 6, 2023
6 tasks
cmaglie
pushed a commit
to cmaglie/arduino-cli
that referenced
this pull request
Sep 8, 2023
…Port` in `GetPort` (arduino#2297) * Change GetPort's returned type to rpc.Port * Use LoadSketch in runUploadCommand
6 tasks
cmaglie
added a commit
that referenced
this pull request
Sep 11, 2023
…#2304 (#2305) * Add support for default build profile (#2203) * Add support for default profile to compile command * Add support for default profiles to upload command * Add TestCompileWithDefaultProfile to integration tests * Get the profile's FQBN if it's not already specified in the request * Update documentation regarding sketch projects * Added integration tests for all default_profile cases * Reverted old sketch_with_profile test --------- Co-authored-by: Cristian Maglie <[email protected]> * [skip-changelog] Use `LoadSketch` in upload function and return `rpc.Port` in `GetPort` (#2297) * Change GetPort's returned type to rpc.Port * Use LoadSketch in runUploadCommand --------- Co-authored-by: MatteoPologruto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
No changes, the gRPC interface is used to avoid accessing
arduinopackage directly.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Related to #1948