-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cryptic error messages returned from Compile #1848
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
- Coverage 36.33% 36.26% -0.07%
==========================================
Files 232 232
Lines 19496 19499 +3
==========================================
- Hits 7083 7071 -12
- Misses 11585 11597 +12
- Partials 828 831 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
After merging this PR, please update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this fixes #1812
Thanks Cristian!
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Fix the error messages from
compile
, they were not correctly encoded in the response.The message
grpc: error while marshaling: proto: Marshal called with nil
appeared instead of the real error message. See Compilation error: grpc: error while marshaling: proto: Marshal called with nil #1812 for details.The correct error message is outputted.
No
Fix Compilation error: grpc: error while marshaling: proto: Marshal called with nil #1812