Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cryptic error messages returned from Compile #1848

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 24, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Fix the error messages from compile, they were not correctly encoded in the response.
  • What is the new behavior?
    The correct error message is outputted.

@cmaglie cmaglie self-assigned this Aug 24, 2022
@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: CLI Related to the command line interface topic: gRPC Related to the gRPC interface criticality: high Of high impact criticality: highest Of highest impact labels Aug 24, 2022
@cmaglie cmaglie requested a review from per1234 August 24, 2022 10:39
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1848 (dbfd94b) into master (f43c9ec) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
- Coverage   36.33%   36.26%   -0.07%     
==========================================
  Files         232      232              
  Lines       19496    19499       +3     
==========================================
- Hits         7083     7071      -12     
- Misses      11585    11597      +12     
- Partials      828      831       +3     
Flag Coverage Δ
unit 36.26% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/daemon/daemon.go 0.00% <0.00%> (ø)
arduino/monitor/monitor.go 41.05% <0.00%> (-6.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kittaakos
Copy link
Contributor

kittaakos commented Aug 24, 2022

I have verified it inside IDE2.

Steps I did:

  • Download the latest nightly IDE2 build,

  • Started IDE2, checked the version,

    Version: 2.0.0-rc9.2.nightly-20220824
    Date: 2022-08-24T03:48:57.272Z
    CLI Version: git-snapshot [04e70c53]
    
    Copyright © 2022 Arduino SA
    
  • Without selecting a board, I compiled. It failed with the Marshal called with nil error. ✅

    grpc: error while marshaling: proto: Marshal called with nil
    
    Compilation error: grpc: error while marshaling: proto: Marshal called with nil
    
  • I built the CLI manually from the cmaglie:fix_compile_err_marshaling branch.

    % git rev-parse --short HEAD
    dbfd94b8
    
  • I dropped the CLI into the latest nightly IDE2 and ran a verify without setting the board. I could see the expected Missing FQBN (Fully Qualified Board Name) message. ✅

    Missing FQBN (Fully Qualified Board Name)
    
    Compilation error: Missing FQBN (Fully Qualified Board Name)
    
    Screen Shot 2022-08-24 at 13 04 53

Thank you!

@kittaakos
Copy link
Contributor

After merging this PR, please update the test_1 branch from the master. Thank you!

@per1234 per1234 added topic: code Related to content of the project itself and removed topic: CLI Related to the command line interface labels Aug 24, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1812

Thanks Cristian!

@cmaglie cmaglie merged commit 42043f6 into arduino:master Aug 24, 2022
@cmaglie cmaglie deleted the fix_compile_err_marshaling branch August 24, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: high Of high impact criticality: highest Of highest impact topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error: grpc: error while marshaling: proto: Marshal called with nil
3 participants