Skip to content

Commit

Permalink
grpc: drop deprecated query field
Browse files Browse the repository at this point in the history
  • Loading branch information
alessio-perugini committed Oct 25, 2023
1 parent b7ce9c8 commit 6e14752
Show file tree
Hide file tree
Showing 4 changed files with 255 additions and 270 deletions.
4 changes: 0 additions & 4 deletions commands/lib/search.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ func LibrarySearch(ctx context.Context, req *rpc.LibrarySearchRequest) (*rpc.Lib
func searchLibrary(req *rpc.LibrarySearchRequest, lm *librariesmanager.LibrariesManager) *rpc.LibrarySearchResponse {
res := []*rpc.SearchedLibrary{}
query := req.GetSearchArgs()
if query == "" {
query = req.GetQuery()
}

matcher := MatcherFromQueryString(query)

for _, lib := range lm.Index.Libraries {
Expand Down
4 changes: 4 additions & 0 deletions docs/UPGRADING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ Here you can find a list of migration guides to handle breaking changes between

## 0.36.0

### gRPC `cc.arduino.cli.commands.v1.LibrarySearchRequest` message has been changed.

The `query` field has been removed, use `search_args` instead.

### CLI `core list` and `core search` changed JSON output.

Below is an example of the response containing an object with all possible keys set.
Expand Down
Loading

0 comments on commit 6e14752

Please sign in to comment.