refactor find_includes #3020
alessio-perugini
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
check-go-task.yml
on: push
run-determination
0s
Matrix: build
Matrix: check-config
Matrix: check-errors
Matrix: check-formatting
Matrix: check-license-headers
Matrix: check-outdated
Matrix: check-style
Annotations
11 errors
|
check-formatting (./)
Process completed with exit code 1.
|
|
check-style (./):
arduino/builder/detector/detector.go#L185
exported method SketchLibrariesDetector.IncludeFolders should have comment or be unexported
|
|
check-style (./):
arduino/builder/detector/detector.go#L247
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
|
|
check-style (./):
arduino/builder/detector/detector.go#L487
don't use ALL_CAPS in Go names; use CamelCase
|
|
check-style (./):
arduino/builder/detector/detector.go#L487
exported var INCLUDE_REGEXP should have comment or be unexported
|
|
check-style (./):
arduino/builder/detector/detector.go#L489
exported function IncludesFinderWithRegExp should have comment or be unexported
|
|
check-style (./):
arduino/builder/detector/detector.go#L510
exported type SourceFile should have comment or be unexported
|
|
check-style (./):
arduino/builder/detector/detector.go#L531
exported method SourceFile.Equals should have comment or be unexported
|
|
check-style (./):
arduino/builder/detector/detector.go#L537
comment on exported function MakeSourceFile should be of the form "MakeSourceFile ..."
|
|
check-style (./):
arduino/builder/detector/detector.go#L571
exported method SourceFile.ExtraIncludePath should have comment or be unexported
|
|
check-style (./):
arduino/builder/detector/detector.go#L575
exported method SourceFile.SourcePath should have comment or be unexported
|