Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct value of BLE.connected() #528

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Correct value of BLE.connected() #528

wants to merge 2 commits into from

Conversation

sandeepmistry
Copy link
Contributor

As discussed in #507.

Now it will check:

  • if in peripheral mode and if a central is connected
  • if in central mode and if a peripheral is connected

I've also reverted a2df179 from PR #454 as the change it no longer required with 58c323e.

cc/ @jimaobian

@sandeepmistry
Revert "Jira 857, BLEPeripheral::connected() always returns false, gi…
af07113 
…t 444"

This reverts commit a2df179.
@sandeepmistry
Correct value of BLE.connected()
4efc697 
Now it will check:
- if in peripheral mode and if a central is connected
- if in central mode and if a peripheral is connected
@sandeepmistry sandeepmistry mentioned this pull request Apr 7, 2017
Open
@SidLeung SidLeung added this to the Elnath milestone Apr 10, 2017
@SidLeung
Copy link
Contributor

@sgbihu please review the code change as a solution to,

#507 (comment)

@kitsunami kitsunami removed this from the Elnath milestone Aug 30, 2017
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigdinotech bigdinotech Awaiting requested review from bigdinotech

@russmcinnis russmcinnis Awaiting requested review from russmcinnis

@noelpaz noelpaz Awaiting requested review from noelpaz

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandeepmistry @SidLeung @CLAassistant @kitsunami