Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jira 768 BLE Appearance Value is 0 #493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Mar 23, 2017

Fix issue #367
Solution:
Add service and appearance characteristic in the BLE lib.

Changed files
BLEDevice.cpp - check the local device
BLEDeviceManager.cpp - Change the calls
BLEDeviceManager.h - remove appearance member
BLEProfileManager.cpp - Add GAP service and appearance characteristic
BLEProfileManager.h - Add set/get API

Solution:
  Add service and appearance characteristic in the BLE lib.

Changed files
  BLEDevice.cpp - check the local device
  BLEDeviceManager.cpp - Change the calls
  BLEDeviceManager.h - remove appearance member
  BLEProfileManager.cpp - Add GAP service and appearance characteristic
  BLEProfileManager.h - Add set/get API
@novashah
Copy link

On hold until port to V4.2 is completed.

@alext-mkrs
Copy link

@novashah, did the transition to 4.2 (I assume that's the nRF FW version) happen?
If not, will it happen, in view of the discontinuation?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants