Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textarea): add props textareaAttrs for textarea #3303

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

yiwwhl
Copy link
Contributor

@yiwwhl yiwwhl commented Sep 19, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

textarea 组件缺少透传的方案,当我想要定制 textarea 的 enterKeyHint 的时候,发现无法做到,只能使用原生的 textarea 实现

Solution

增加 textareaAttrs 以便于传入 enterKeyHint 等原生属性,应该能解决该问题

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
textarea 支持textarea的textareaAttrs属性 Support textareaAttrs attribute for textarea

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Copy link

codesandbox bot commented Sep 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@oljc
Copy link
Member

oljc commented Sep 19, 2024

Ref. #1106

@oljc oljc added the 💪🏻 Enhancement feature enhancement label Sep 19, 2024
@yiwwhl
Copy link
Contributor Author

yiwwhl commented Sep 20, 2024

Should I be concerned about these errors in the pipeline?

@oljc oljc merged commit edc16ce into arco-design:main Sep 20, 2024
2 of 4 checks passed
@flsion flsion added this to the 2.56.3 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪🏻 Enhancement feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants