Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): scroll-to-first-error error in nested form items #2707

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

oljc
Copy link
Member

@oljc oljc commented Sep 15, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

表单项上的id未经处理导致嵌套时报错
#2703
#2702

Solution

增加函数getFormElementId统一生成,将field中的特殊字符过滤替换。

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
form 修复field为数组对象时滚动报错问题 scroll-to-first-error throws error in nested form items Close #2703 , Close #2702

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@flsion flsion self-assigned this Sep 15, 2023
@flsion flsion added the 🐛 Bug Something isn't working label Sep 15, 2023
@flsion flsion added this to the 2.51.2 milestone Sep 15, 2023
@flsion flsion merged commit d835474 into arco-design:main Sep 15, 2023
2 of 4 checks passed
@oljc oljc deleted the fix-scroll-to-first-error branch February 2, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scroll-to-first-error在嵌套表单项中会报错 fix: 修复scroll-to-first-error在数组中的表现
2 participants