Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use husky set to add pre-commit command #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hkhere
Copy link
Contributor

@hkhere hkhere commented Jun 19, 2023

Types of changes

  • New feature
  • Bug fix
  • Documentation change
  • Coding style change
  • Refactoring
  • Performance improvement
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change

Background and context

every time the npm script command prepare( "prepare": "husky install && husky add .husky/pre-commit 'npm run pre-commit'") is run, it will cause husky to add anothernpm run pre-commit item to the .husky/pre-commit script, which is not what we want.

Solution

How is the change tested?

change husky add to husky set

Changelog

Changelog(CN) Changelog(EN) Related issues

Checklist:

  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to master branch)

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant