enhancement: add transparent background to sponsor images #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcarilla
approved these changes
Sep 1, 2024
jelly
reviewed
Sep 4, 2024
templates/public/donate.html
Outdated
| @@ -50,7 +50,7 @@ <h3>Commercial sponsors and contributions</h3> | |||
| of git commits and software packages, GnuPG keys, and SSH accounts.</p> | |||
|
|
|||
| <a href="https://nitrokey.com/" title="Nitrokey"> | |||
| <img src="{% static "nitrokey_logo.png" %}" | |||
| <img width="240" src="{% static "nitrokey_logo.png" %}" | |||
There was a problem hiding this comment.
Why not resize the original image back to 420px?
There was a problem hiding this comment.
Because of the white boarder that it carries 😅
There was a problem hiding this comment.
This logo is only shown here, it was 240px width, so we can just retain that:
magick convert -resize 240 nitrokey_logo.png nitrokey_logo_res.png
jelly
reviewed
Sep 4, 2024
templates/public/donate.html
Outdated
| @@ -50,7 +50,7 @@ <h3>Commercial sponsors and contributions</h3> | |||
| of git commits and software packages, GnuPG keys, and SSH accounts.</p> | |||
|
|
|||
| <a href="https://nitrokey.com/" title="Nitrokey"> | |||
| <img src="{% static "nitrokey_logo.png" %}" | |||
| <img width="240" src="{% static "nitrokey_logo.png" %}" | |||
There was a problem hiding this comment.
This logo is only shown here, it was 240px width, so we can just retain that:
magick convert -resize 240 nitrokey_logo.png nitrokey_logo_res.png
jelly
approved these changes
Sep 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the images sometimes were not using transparent background or were a little pixelated, which this PR tries to fix.
Old:
New:
