This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
[ruby] Upgrade rubocop to version 1.51.0 #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 1.40.0 → ~> 1.51.0) · Repo · Changelog
Release Notes
1.51.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 70 commits:
Cut 1.51 to celebrate RubyKaigi 2023Update ChangelogFix a false positive for `Lint/IncompatibleIoSelectWithFiberScheduler`Add new `Style/ExactRegexpMatch` copMark some cops as unsafeMerge pull request #11872 from Bhacaz/fix_development_dependencies_cop_with_argumentsFix Gemspec/DevelopmentDependencies not trigger when add_development_dependency has more then one argumentsMerge pull request #11870 from fatkodima/fix-hash_except-incorrect-argumentsFix a false positive for when method's receiver/argument is not the same as block key argumentFix an error for `Style/IfInsideElse`Make `Style/Semicolon` aware of string interpolationMerge pull request #11510 from sambostock/useless-assignment-bugFix `Lint/UselessAssignment` false positiveMerge pull request #11865 from koic/fix_a_false_positive_for_naming_constant_nameFix an error for `Naming/ConstantName`[Fix #11861] Fix a false positive for `Layout/SpaceAfterSemicolon`Merge pull request #11863 from koic/fix_an_incorrect_autocorrect_for_style_guard_clause[Fix #11862] Fix an incorrect autocorrect for `Style/GuardClause`Merge pull request #11859 from ydah/add-rubocop-factory_bot-to-suggested-extensionsAdd rubocop-factory_bot to suggested extensions and extension docAdd dev docs on preventing correction clobberingMerge pull request #11858 from reitermarkus/patch-2Fix `find_end_line` for blocks.Fix a build error[Fix #11597] Add autocorrection for `Lint/UselessAssignment`Simplify `inspect` output[Fix #11849] Fix an error for `Style/ConditionalAssignment`Add autocorrection for `Style/CombinableLoops`Use RuboCop RSpec 2.22Merge pull request #11855 from r7kamura/style-combinable-loops-refactorRemove unnecessary `Symbol#to_s` used for Ruby 2.6- compatibilityMerge pull request #11853 from koic/fix_an_incorrect_autocorrect_for_style_eval_with_location[Fix #11852] Fix an incorrect autocorrect for `Style/EvalWithLocation`Add autocorrection for `Lint/Void`Add autocorrection for `Naming/MemoizedInstanceVariableName`Use RuboCop RSpec 2.21[Fix #11846] Fix a false positive for `Lint/RedundantStringCoercion`[Fix #11844] Fix a false positive for `Style/RedundantLineContinuation`Fix an error for `Style/IfUnlessModifier`Merge pull request #11835 from koic/fix_an_error_for_style_require_orderFix an error for `Style/RequireOrder`[Doc] Tweak command prompt characterMerge pull request #11826 from r7kamura/lint-top-level-return-excludeMerge pull request #11824 from r7kamura/lint-top-level-return-autocorrectAdd autocorrection for `Lint/TopLevelReturnWithArgument`Exclude `**/*.jb` from `Lint/TopLevelReturnWithArgument`Merge pull request #11823 from koic/fix_an_error_for_layout_space_inside_block_bracesMerge pull request #11816 from thomthom/patch-1Add rubocop-sketchup to list of third party extensions.Merge pull request #11821 from r7kamura/fix-empty-conditional-body[Fix #11820] Fix `Lint/EmptyConditionalBody` false-positives for commented empty `elsif` body[Fix #11822] Fix an error for `Layout/SpaceInsideBlockBraces`Merge pull request #11819 from r7kamura/ambiguous-block-association-autocorrectionAdd autocorrection for `Lint/AmbiguousBlockAssociation`Merge pull request #11818 from koic/use_test_queue_for_rspec4Use test-queue for RSpec 4.0 (dev)[Doc] Syntax highlight for `Style/Copyright`[Fix #11812] Fix a false negative for `Style/Attr`Make `Style/CollectionCompact` aware of `delete_if`Specify rspec/rspec-metagem instead of rspec/rspec[Doc] Remove incorrect text highlighting for `Style/Documentation`[Doc] Fix the doc for `Style/ColonMethodCall`Merge pull request #11810 from koic/fix_an_incorrect_autocorrect_for_naming_rescued_exceptions_variable_name[Doc] Tweak example layout for `Style/InvertibleUnlessCondition`Remove incorrect examples for `Style/InvertibleUnlessCondition`[Fix #11809] Fix an incorrect autocorrect for `Naming/RescuedExceptionsVariableName`Use RuboCop RSpec 2.20Fix a false positive for `Style/RegexpLiteral`Drop Ruby 2.6 runtime supportSwitch back the docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands