Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Test Dashboard Controller params; resolves #154. #163

Closed
wants to merge 1 commit into from

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Aug 21, 2018

GitHub issue(s):

#154

What does this Pull Request do?

This should cover the missing params coverage in the Dashboard Controller test.

How should this be tested?

  • TravisCI turns green
  • CodeCov goes up, and this line is coverage in the report

@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files          34       34           
  Lines         425      425           
=======================================
  Hits          387      387           
  Misses         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9aabf...a184b4d. Read the comment docs.

@ruebot
Copy link
Member Author

ruebot commented Aug 21, 2018

Hrm. Looks like I have some more research to do.

@ruebot ruebot added the on hold label Dec 13, 2018
@ruebot ruebot closed this Mar 31, 2020
@ruebot ruebot deleted the issue-154 branch March 31, 2020 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant