Fix transaction sender methods and error handling #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "confirmationThreshold" and "timeout" parameters are already configured by default in transaction_sender which makes them optional here.
It's better to throw an error object because this provides more information about the error, including a stack trace, which can help with debugging.
Destructuring assignment unnecessarily renamed
samuelmanzanera
approved these changes
Dec 6, 2023
samuelmanzanera
added
quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes several issues in the
TransactionSenderclass and improves error handling. The changes include:Updating the
sendmethod inExtendedTransactionBuilderto make theconfirmationThresholdandtimeoutparameters optional.Removing an unnecessary return statement in the
TransactionSenderconstructor.Fixing error handling by throwing an
Errorobject instead of a string.Fixing a destructuring assignment in the
sendmethod.