fix(rpc): Exception are transformed to rpc Failures.

archethic-foundation · Jun 20, 2024 · 5877f22 · 5877f22
1 parent 9d949a4
commit 5877f22
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/domain/rpc/command_dispatcher.dart b/lib/domain/rpc/command_dispatcher.dart
@@ -145,7 +145,7 @@ class CommandDispatcher {
         .handle(command.command)
         .then(
           command.completer.complete,
-          onError: (error) => command.completer.complete(Result.failure(error)),
+          onError: command.completer.completeError,
         )
         .whenComplete(_process);
   }

diff --git a/lib/infrastructure/rpc/dto/rpc_command_handler.dart b/lib/infrastructure/rpc/dto/rpc_command_handler.dart
@@ -35,6 +35,9 @@ abstract class RPCCommandHandler<C, R> {
     } on TypeError catch (e, stack) {
       _logger.severe('Invalid data', e, stack);
       return const Result.failure(awc.Failure.invalidParams);
+    } catch (e, stack) {
+      _logger.severe('Command failed', e, stack);
+      return const Result.failure(awc.Failure.other);
     }
   }
 }