Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug that prevents saving tab name changes in a tabbed report #11672

Merged

Conversation

CWDamm-Kint
Copy link
Contributor

@CWDamm-Kint CWDamm-Kint commented Dec 4, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Two data-binds needed merging in the tabbed report htm file, which meant that the binding for the name field wasn't working properly when editing tabs.

Issues Solved

Closes #11617

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

NA

@chiatt chiatt self-assigned this Dec 12, 2024
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does improve activation of the dirty state when a name is changed (although I still had to switch between tabs to get it to fire). However, it seems there is more to the problem than the dirty state. If a user saves their tab name changes, their edits are not committed to the database and the changes are lost on page refresh.

@chiatt
Copy link
Member

chiatt commented Dec 12, 2024

This does improve activation of the dirty state when a name is changed (although I still had to switch between tabs to get it to fire). However, it seems there is more to the problem than the dirty state. If a user saves their tab name changes, their edits are not committed to the database and the changes are lost on page refresh.

@CWDamm-Kint You can disregard my last message. There was an issue with my local instances preventing the save. Your changes looks good. If you resolve the merge conflict, I can go ahead and approve this.

@chiatt chiatt merged commit af5ebcb into archesproject:dev/7.6.x Dec 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants