Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with arches 7.6 #18

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jul 17, 2024

Probably easiest to review commit by commit.

I bumped the version to 0.1.3, but do we prefer 0.2.0? Bumped version to 0.2.0

You don't have to keep the commit(s) that deletes the frontend infra if you decide it's best to keep a close 1:1 with the application templates. (ask me, i'll update)

I kept the test_settings.py as small as possible for clarity. You can pass it to manage.py:

python manage.py check --settings="arches_templating.tests.test_settings"

@jacobtylerwalls jacobtylerwalls requested a review from chiatt July 17, 2024 18:57
@jacobtylerwalls jacobtylerwalls marked this pull request as draft July 17, 2024 19:59
Copy link
Member Author

@jacobtylerwalls jacobtylerwalls Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix archesproject/arches#11094 before merging this (as a dotfile, it also breaks other apps' webpack builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review July 18, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant