Remove <LetterCircle>
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnatawnclementawn
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Thanks for testing instructions 👍🏼 This looks good!
A small styling comment regarding styling of the icons which can certainly be punted until polish stages. I feel that it was easier to differentiate between a list and list item in the previous iteration (color & letter-circle) rather than now it's just icon shape
|
Good call, it makes sense to add color back in. |
jacobtylerwalls
force-pushed
the
jtw/remove-letter-circle
branch
from
6785d28 to
5e5f1a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same resolution as arches-lingo ticket
Also see Slack
Verify icons and aria labels appear in tree sidebar and list or item headers.